[PATCH] D138991: [AAPointerInfo] handle multiple offsets in PHI

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

I'm not thrilled about the old PM stuff and we really need to remove it asap, but it's good to go in once the dependence lands.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1538
 
-      // Check if the PHI operand is not dependent on the PHI itself.
+      // Check if the PHI operand is can be traced back to AssociatedValue.
       APInt Offset(
----------------
foad wrote:
> Typo "is can"
^


================
Comment at: llvm/test/CodeGen/AMDGPU/implicitarg-attributes.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: llc < %s | FileCheck %s
----------------
foad wrote:
> Have they?!
^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138991/new/

https://reviews.llvm.org/D138991