[PATCH] D139478: [Support] Forward rvalues instead of moving them

[Alf via Phabricator via llvm-commits]

gAlfonso-bit added a comment.

In D139478#3977132 <https://reviews.llvm.org/D139478#3977132>, @MaskRay wrote:

> Please spend more time on each call site instead of applying easy fixes from some static analyzer. For example, `operator<<(OStream &&OS, const T &Value) {` is for value only (see `!std::is_reference`). `std::move` is intended.

That static analyzer just happens to be clang-tidy. But this isn't even about clang-tidy. You said the && usage is wrong, but the comments say this is for rvalue. The std::move has nothing to do with the &&, despite you saying that was the issue


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139478/new/

https://reviews.llvm.org/D139478