[PATCH] D139478: [Support] Forward rvalues instead of moving them
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 6 22:53:11 PST 2022
MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.
Please spend more time on each call site instead of applying easy fixes from some static analyzer. For example, `operator<<(OStream &&OS, const T &Value) {` is for value only (see `!std::is_reference`). `std::move` is intended.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139478/new/
https://reviews.llvm.org/D139478
More information about the llvm-commits
mailing list