[PATCH] D139448: [llvm-exegesis] Dry run mode

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h:39
+                           InstructionBenchmark::ModeE Mode,
+                           bool BenchmarkDryRun);
 
----------------
courbet wrote:
> Instead of plumbing `BenchmarkDryRun` inside this class, why can't we just not create a `BenchmarkRunner` at all in `llvm-exegesis.cpp` when the flag is true ?
Because that, by definition, does not do what i want it to do.
I want `BenchmarkRunner::runConfiguration()` to get called
up to and including actually assembling the final code that we'd measure
in `for (const std::unique_ptr<const SnippetRepetitor> &Repetitor : Repetitors) {`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139448/new/

https://reviews.llvm.org/D139448