[PATCH] D139448: [llvm-exegesis] Dry run mode

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 01:14:12 PST 2022


courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h:39
+                           InstructionBenchmark::ModeE Mode,
+                           bool BenchmarkDryRun);
 
----------------
Instead of plumbing `BenchmarkDryRun` inside this class, why can't we just not create a `BenchmarkRunner` at all in `llvm-exegesis.cpp` when the flag is true ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139448/new/

https://reviews.llvm.org/D139448



More information about the llvm-commits mailing list