[PATCH] D138934: mlir/tblgen: use std::optional in generation

[Ramkumar Ramachandra via Phabricator via llvm-commits]

artagnon added a comment.

The Windows build is failing, and I don't know why. In light of @kazu's comments on D138984 <https://reviews.llvm.org/D138984>, and his recent commits, I'm tempted to abandon this change, and let him take over the work.



================
Comment at: mlir/lib/Dialect/Shape/IR/Shape.cpp:1337
     return nullptr;
-  Optional<int64_t> dim = getConstantDim();
+  auto dim = getConstantDim();
   if (!dim.has_value())
----------------
jpienaar wrote:
> Why couldn't this be std::optional<int64_t> ?
It could very well be. I suppose it's a matter of style: personally, I prefer `auto` to make the code less brittle to changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138934/new/

https://reviews.llvm.org/D138934