[PATCH] D138934: mlir/tblgen: use std::optional in generation
Jacques Pienaar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 5 15:21:51 PST 2022
jpienaar added inline comments.
================
Comment at: mlir/lib/Dialect/Shape/IR/Shape.cpp:1337
return nullptr;
- Optional<int64_t> dim = getConstantDim();
+ auto dim = getConstantDim();
if (!dim.has_value())
----------------
Why couldn't this be std::optional<int64_t> ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138934/new/
https://reviews.llvm.org/D138934
More information about the llvm-commits
mailing list