[PATCH] D138796: ObjCARC: Try to fix faulty tests

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

In D138796#3975547 <https://reviews.llvm.org/D138796#3975547>, @ahatanak wrote:

> In D138796#3967899 <https://reviews.llvm.org/D138796#3967899>, @dexonsmith wrote:
>
>> In D138796#3957499 <https://reviews.llvm.org/D138796#3957499>, @ahatanak wrote:
>>
>>> I confirmed ARC optimizer hasn't removed the retain/release pairs in both functions at least since October 2017. The retain/release pair in `@"\01-[Top0 _getX]"` can be removed. I'm not sure about the one in `@"\01-[A z]"`.
>>
>> Great progress; seems to me like the regression is old enough it might not be an easy fix. Are you okay with the tests being cleaned up to reflect reality in the meantime?
>
> Yes, I think that's okay. We are tracking this internally, so this can be committed as-is.

In that case, this LGTM.

@arsenm, I'd prefer that you add comments to the two broken cases saying that the optimizer should somehow cleanup those pairs (or move those cases to an XFAIL test), so that if some future person works on this it'll be more clear. Up to you though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138796/new/

https://reviews.llvm.org/D138796