[PATCH] D138796: ObjCARC: Try to fix faulty tests

Tue Dec 6 12:38:16 PST 2022

ahatanak added a comment.

In D138796#3967899 <https://reviews.llvm.org/D138796#3967899>, @dexonsmith wrote:

> In D138796#3957499 <https://reviews.llvm.org/D138796#3957499>, @ahatanak wrote:
>
>> I confirmed ARC optimizer hasn't removed the retain/release pairs in both functions at least since October 2017. The retain/release pair in `@"\01-[Top0 _getX]"` can be removed. I'm not sure about the one in `@"\01-[A z]"`.
>
> Great progress; seems to me like the regression is old enough it might not be an easy fix. Are you okay with the tests being cleaned up to reflect reality in the meantime?

Yes, I think that's okay. We are tracking this internally, so this can be committed as-is.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138796/new/

https://reviews.llvm.org/D138796