[PATCH] D139337: [IRSim] Treat Branch OperVals different from regular operands

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:859
 
+    assert(RelBlockLocsA.size() == ABL.size() &&
+           "Block information vectors not the same size.");
----------------
paquette wrote:
> Why are these asserts after the `if`?
If the sizes of the block information between the two branch instructions do not match, then we don't need to worry about whether the information contained in them is correct.  This checks consistency between the two data structures concerning the same branch.  I think this could go before the if statements, but I also don't know if it matters the order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139337/new/

https://reviews.llvm.org/D139337