[PATCH] D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI

[Andrew Ng via Phabricator via llvm-commits]

andrewng abandoned this revision.
andrewng added a comment.

These changes are not required. Ensuring that `libc++.lib` appears before `msvcprt.lib` solves the problem. Therefore, relying on the `#pragma comment(lib, "libc++.lib")` in the `libc++` config doesn't really work for this Windows configuration. The `libc++` testing also explicitly lists the link libraries with `libc++.lib` before `msvcprt.lib` which is why no problems are seen. However, the `libc++` static test configuration does appear to be a mix of static and dynamic but that's another issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136605/new/

https://reviews.llvm.org/D136605