[PATCH] D137819: [XCOFF] support the overflow section (only relocation overflow is handled).

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:931
+  // Write the Physical Address and Virtual Address. In an object file these
+  // are the same, except for in the the overflow section header.
+  // In the overflow section header the Physical Address specifies the number
----------------
jhenderson wrote:
> No need for "for" here. Also duplicate "the".
> 
> This comment seems to basically be saying the same thing as the new one in the header. I don't think we need both as it's just repeating information. @DiggerLin, what do you think?
agree with James.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137819/new/

https://reviews.llvm.org/D137819