[PATCH] D137819: [XCOFF] support the overflow section (only relocation overflow is handled).

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:111
+  // The physical/virtual address of the section. For an object file these
+  // values are equivalent, except for in the the overflow section header, where
+  // the physical address specifies the number of relocation entries and the
----------------



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:113
+  // the physical address specifies the number of relocation entries and the
+  // virtual Address specifies the number of line number entries.
+  // TODO: Divide Address into PhysicalAddress and VirtualAddress when line
----------------



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:115
+  // TODO: Divide Address into PhysicalAddress and VirtualAddress when line
+  // number is supported.
   uint64_t Address;
----------------



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:931
+  // Write the Physical Address and Virtual Address. In an object file these
+  // are the same, except for in the the overflow section header.
+  // In the overflow section header the Physical Address specifies the number
----------------
No need for "for" here. Also duplicate "the".

This comment seems to basically be saying the same thing as the new one in the header. I don't think we need both as it's just repeating information. @DiggerLin, what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137819/new/

https://reviews.llvm.org/D137819