[PATCH] D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added a comment.

In D138982#3974293 <https://reviews.llvm.org/D138982#3974293>, @Esme wrote:

> Hi @DiggerLin, thank you for your review. I'm also confused by the description from the doc, if my understanding is correct, according to the doc, the FixedValue will ignore the value of `Fixup.getOffset()`, because `the address of the csect containing the branch instruction to be modified` equals to `SectionMap[ParentSec]->Address + Layout.getFragmentOffset(Fragment)`. This is obviously incorrect. I have tested LNT and bootstrap for this patch under the options of `-fintegrated-as -ffunction-sections`, and both are clean.



In D138982#3974293 <https://reviews.llvm.org/D138982#3974293>, @Esme wrote:

> Hi @DiggerLin, thank you for your review. I'm also confused by the description from the doc, if my understanding is correct, according to the doc, the FixedValue will ignore the value of `Fixup.getOffset()`, because `the address of the csect containing the branch instruction to be modified` equals to `SectionMap[ParentSec]->Address + Layout.getFragmentOffset(Fragment)`. This is obviously incorrect. I have tested LNT and bootstrap for this patch under the options of `-fintegrated-as -ffunction-sections`, and both are clean.

I agree with you, I asked the problem in our slack channel and wait for confirm, if it is doc error,  we should the ask doc to be modified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138982/new/

https://reviews.llvm.org/D138982