[PATCH] D138982: [XCOFF] adjust the Fixedvalue for R_RBR relocations.
Esme Yi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 6 06:17:59 PST 2022
Esme added a comment.
Hi @DiggerLin, thank you for your review. I'm also confused by the description from the doc, if my understanding is correct, according to the doc, the FixedValue will ignore the value of `Fixup.getOffset()`, because `the address of the csect containing the branch instruction to be modified` equals to `SectionMap[ParentSec]->Address + Layout.getFragmentOffset(Fragment)`. This is obviously incorrect. I have tested LNT and bootstrap for this patch under the options of `-fintegrated-as -ffunction-sections`, and both are clean.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138982/new/
https://reviews.llvm.org/D138982
More information about the llvm-commits
mailing list