[PATCH] D136514: [AA][Intrinsics] Add separate_storage assumptions.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/SeparateStorageAliasAnalysis.cpp:53
+  if (!PtrA || !PtrB)
+    return AliasResult::MayAlias;
+
----------------
I don't think Loc without pointer is legal in this context. Should be fine to drop this check.


================
Comment at: llvm/lib/Analysis/SeparateStorageAliasAnalysis.cpp:58
+
+  for (auto &AssumeVH : AC.assumptions()) {
+    if (!AssumeVH)
----------------
Hm, I wonder if we can use assumptionsFor() here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136514/new/

https://reviews.llvm.org/D136514