[PATCH] D136514: [AA][Intrinsics] Add separate_storage assumptions.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 03:38:43 PST 2022


nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/Attributes.td:183
+/// operands do not alias.
+def SeparateStorage : EnumAttr<"separate_storage", [ParamAttr]>;
+
----------------
It doesn't make sense to add an actual attribute for this. This would allow you to write something like `define foo(ptr separate_storage %arg)`, and what is that supposed to mean?

We should allow separate_storage as an assume operand bundled only -- there's not fundamental reason why these bundled have to map onto attributes. That's just all we needed historically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136514/new/

https://reviews.llvm.org/D136514



More information about the llvm-commits mailing list