[PATCH] D139412: [AMDGPU] Change handling of s_endpgm's optional operand. NFC.

[Jay Foad via Phabricator via llvm-commits]

foad added a subscriber: dp.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:1942
 
-multiclass SOPP_Real_32_gfx11<bits<7> op, string real_name = !cast<SOPP_Pseudo>(NAME).Mnemonic # " "> {
-  def _gfx11 : SOPP_Real_32<op, !cast<SOPP_Pseudo>(NAME), real_name>,
+multiclass SOPP_Real_32_gfx11<bits<7> op> {
+  def _gfx11 : SOPP_Real_32<op, !cast<SOPP_Pseudo>(NAME), !cast<SOPP_Pseudo>(NAME).Mnemonic>,
----------------
@dp what do you think of this patch? Personally I like it because it simplifies all these SOPP_Real multiclasses, by removing all the machinery for passing around and overriding real_name. But I am open to other opinions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139412/new/

https://reviews.llvm.org/D139412