[PATCH] D139412: [AMDGPU] Change handling of s_endpgm's optional operand. NFC.
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 6 03:55:54 PST 2022
foad created this revision.
foad added a reviewer: AMDGPU.
Herald added subscribers: kosarev, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.
s_endpgm is a special SOPP instruction in that its operand is optional
and if it is not present then we don't want to print a space after the
mnemonic.
Previously this was handled by defaulting real_name to the mnemonic with
a trailing space, and having s_endpgm override it to be the mnemonic
with no trailing space.
This patch implements a different approach where all SOPP instructions
except for s_endpgm include a leading space in their AsmOperands.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D139412
Files:
llvm/lib/Target/AMDGPU/SOPInstructions.td
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139412.480425.patch
Type: text/x-patch
Size: 13822 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221206/eae344ff/attachment.bin>
More information about the llvm-commits
mailing list