[PATCH] D139000: [AMDGPU] Clear bodies of function with incompatible features

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh marked an inline comment as done.
Pierre-vh added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUClearIncompatibleFunctions.cpp:87
+
+FeatureBitset ExpandImpliedFeatures(const FeatureBitset &Features) {
+  FeatureBitset Result = Features;
----------------
Joe_Nash wrote:
> Does this need to reach a fixed point over features implying each other? Maybe that has already been done in the Implies data structure.
It just needs to expand everything, not sure how the Implies data structure works exactly but I _think_ you can have implied feature that imply other feature, so there's a need to be recursive.
This function is inspired by `SetImpliedBits` in `MCSubtargetInfo.cpp` (which is private)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000