[PATCH] D139000: [AMDGPU] Clear bodies of function with incompatible features

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added a comment.

Overall this is looking quite good.

> do this on an "opt-in" basis

Makes sense to me



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUClearIncompatibleFunctions.cpp:87
+
+FeatureBitset ExpandImpliedFeatures(const FeatureBitset &Features) {
+  FeatureBitset Result = Features;
----------------
Does this need to reach a fixed point over features implying each other? Maybe that has already been done in the Implies data structure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000