[PATCH] D137982: Reland "[pgo] Avoid introducing relocations by using private alias""

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:826
 
+static inline Constant *getFuncAddrForProfData(Function *Fn) {
+  auto *Int8PtrTy = Type::getInt8PtrTy(Fn->getContext());
----------------
@xur, I think I've worked through a solution that will work here, and solve the issue for Fuchsia that we discussed. 

Does this look correct to you?  The logic is now: if we need the address for profd, get a private alias when we can. If the function is a comdat, only get a hidden one, if possible. 

Do you foresee any issues with this approach?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137982/new/

https://reviews.llvm.org/D137982