[PATCH] D137982: Reland "[pgo] Avoid introducing relocations by using private alias""

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 16:38:41 PST 2022


paulkirth added inline comments.


================
Comment at: compiler-rt/test/profile/instrprof-discarded-comdat.ll:1
+; Check that instrprof does not introduce references to discaded sections when
+; using comdats.
----------------
This test is a bit redundant with the one above. I had some trouble updating the CMake dependencies of the `check-profile` target to include `opt` and `llc`, so I included the c++ test.

I'm happy to remove either one, but I'm not certain which one is preferable. If we keep this version, we also need to update the CMake files to reflect the new dependency. I don't think there are any changes required for the C++ test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137982/new/

https://reviews.llvm.org/D137982



More information about the llvm-commits mailing list