[PATCH] D137982: Reland "[pgo] Avoid introducing relocations by using private alias""

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 16:30:54 PST 2022


paulkirth updated this revision to Diff 480279.
paulkirth added a comment.

Restore using hidden alias with COMDAT functions. It does impact the number of relocations, and is a better semantic match. It also eliminates an entry in the dynamic symbol table.

- Add compile tests for the comdat and non-comdat cases
- add an end-to-end test in compiler-rt's profile tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137982/new/

https://reviews.llvm.org/D137982

Files:
  compiler-rt/test/profile/instrprof-discarded-comdat.cpp
  compiler-rt/test/profile/instrprof-discarded-comdat.ll
  llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
  llvm/test/Transforms/PGOProfile/comdat.ll
  llvm/test/Transforms/PGOProfile/prof_avoid_relocs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137982.480279.patch
Type: text/x-patch
Size: 13965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221206/27aeb051/attachment.bin>


More information about the llvm-commits mailing list