[PATCH] D138658: [DebugInfo] Store optional DIFile::Source as pointer

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 01:59:30 PST 2022


Hahnfeld updated this revision to Diff 480022.
Hahnfeld added a comment.

I updated the patch to use `MDString::get` directly and represent the empty file by a non-`nullptr`. I'm not sure yet if there are any bad implications by not having a "canonical" `MDString`...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138658/new/

https://reviews.llvm.org/D138658

Files:
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/lib/IR/LLVMContextImpl.h
  llvm/unittests/IR/DebugInfoTest.cpp
  llvm/unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138658.480022.patch
Type: text/x-patch
Size: 9852 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221205/042608bf/attachment.bin>


More information about the llvm-commits mailing list