[PATCH] D139223: [ORC] Move LinkGraphMaterializationUnit for testing (NFC)

Sat Dec 3 11:30:20 PST 2022

dblaikie added a comment.

In D139223#3968060 <https://reviews.llvm.org/D139223#3968060>, @lhames wrote:

> I haven't had a chance for a proper read yet -- will do that when I get back from vacation next week.
>
> My first thought is that, following the reasoning in https://reviews.llvm.org/D130221, we should aim to merge `MachOPlatform::isInitializerSection` and `hasMachOInitSection` into a new function in `ObjectFileInterface.h` and use that.
>
> If we do that we may find that this is testable in `LinkGraphTests.cpp` rather than `ObjectLinkingLayer`.

Ah, awesome - yeah, that does look like a good thing to deduplicate.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139223/new/

https://reviews.llvm.org/D139223