[PATCH] D139223: [ORC] Move LinkGraphMaterializationUnit for testing (NFC)

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 17:03:56 PST 2022


lhames added a comment.

I haven't had a chance for a proper read yet -- will do that when I get back from vacation next week.

My first thought is that, following the reasoning in https://reviews.llvm.org/D130221, we should aim to merge `MachOPlatform::isInitializerSection` and `hasMachOInitSection` into a new function in `ObjectFileInterface.h` and use that.

If we do that we may find that this is testable in `LinkGraphTests.cpp` rather than `ObjectLinkingLayer`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139223/new/

https://reviews.llvm.org/D139223



More information about the llvm-commits mailing list