[PATCH] D137982: Reland "[pgo] Avoid introducing relocations by using private alias""

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 18:48:41 PST 2022


paulkirth updated this revision to Diff 479790.
paulkirth added a comment.

Avoid complexity with COMDAT, since we don't get any benefit in those cases. We
actually end up generating an alias that always is the same linkage and
visibility as the original function, so just use the public symbol, which is
more correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137982/new/

https://reviews.llvm.org/D137982

Files:
  compiler-rt/test/profile/instrprof-discarded-comdat.ll
  llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
  llvm/test/Transforms/PGOProfile/prof_avoid_relocs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137982.479790.patch
Type: text/x-patch
Size: 4590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221203/fe30acd8/attachment.bin>


More information about the llvm-commits mailing list