[PATCH] D138781: [RISCV] Check missed Expected<T> result

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 00:14:39 PST 2022


jrtc27 added inline comments.


================
Comment at: llvm/test/ExecutionEngine/JITLink/RISCV/ELF_pc_indirect.s:49
+        auipc a0, %pcrel_hi(external_data)
+        sw  a0, %pcrel_lo(test_pcrel32_s)(a0)
+
----------------
Why is this a test for the case you're fixing? This is valid input so shouldn't be hitting an error path in the first place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138781/new/

https://reviews.llvm.org/D138781



More information about the llvm-commits mailing list