[PATCH] D138781: [RISCV] Check missed Expected<T> result

Dmitry Kurtaev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 00:05:27 PST 2022


dkurt added a comment.

In D138781#3964747 <https://reviews.llvm.org/D138781#3964747>, @dblaikie wrote:

> Is it possible to test the actual error case too? (show that the error is propagated/reported?)
>
> Looks good though - if you happen to be able to conjure up the failing test too, that'd be great!

Not sure I could handle it. The added test is similar to one for `R_RISCV_PCREL_LO12_I` (success path) but I have not found any existing checks for fail results of `getRISCVPCRelHi20`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138781/new/

https://reviews.llvm.org/D138781



More information about the llvm-commits mailing list