[PATCH] D139140: [ModuleInliner] Add MLPriority
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 1 16:27:03 PST 2022
mtrofin added inline comments.
================
Comment at: llvm/lib/Analysis/InlineOrder.cpp:197
+private:
+ int Cost;
+};
----------------
kazu wrote:
> mtrofin wrote:
> > can you initialize it here - lowers the risk of undefined values later (like if somehow the ctor forgets to initialize it)
> >
> >
> Would `int Cost = INT_MAX;` be OK here? The actual initialization is a bit complicated.
sgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139140/new/
https://reviews.llvm.org/D139140
More information about the llvm-commits
mailing list