[PATCH] D139140: [ModuleInliner] Add MLPriority

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 16:04:55 PST 2022


kazu added a comment.

In D139140#3965039 <https://reviews.llvm.org/D139140#3965039>, @mtrofin wrote:

> can you also add a test? thanks!

Will do.



================
Comment at: llvm/lib/Analysis/InlineOrder.cpp:197
+private:
+  int Cost;
+};
----------------
mtrofin wrote:
> can you initialize it here - lowers the risk of undefined values later (like if somehow the ctor forgets to initialize it)
> 
> 
Would `int Cost = INT_MAX;` be OK here?  The actual initialization is a bit complicated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139140/new/

https://reviews.llvm.org/D139140



More information about the llvm-commits mailing list