[PATCH] D135808: [LoopInterchange] Correcting the profitability checking for vectorization

[Congzhe Cao via Phabricator via llvm-commits]

congzhe added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:1148
+  LLVM_DEBUG(dbgs() << "Cost = " << Cost << "\n");
+  if (abs(Cost) < LoopInterchangeCostMeaningfulnessThreshold)
+    if (Cost < -LoopInterchangeCostThreshold)
----------------
Is it possible to make `LoopInterchangeCostMeaningfulnessThreshold` an opt flag so we can assign its value more flexibly? Possibly rename it to `LegacyCostModelThreshold` or whatever is more appropriate.

```
static cl::opt<int> LegacyCostModelThreshold(
    "legacy-cost-threshold", cl::init(10), cl::Hidden,
    cl::desc("The threshold for the legacy cost model to be considered."));
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135808/new/

https://reviews.llvm.org/D135808