[PATCH] D135808: [LoopInterchange] Correcting the profitability checking for vectorization

[Congzhe Cao via Phabricator via llvm-commits]

congzhe added a comment.

I would suggest to revise the summary and/or the title to describe that this patch now also addresses the endless interchange problem, in addition to correction in `isProfitableForVectorization()`.



================
Comment at: llvm/test/Transforms/LoopInterchange/profitability.ll:238
+
+; PROFIT: --- !Passed
+; PROFIT-NEXT: Pass:            loop-interchange
----------------
I would suggest to apply `--check-prefix=PROFIT` only to `interchange_05()`  and not to other existing tests. Because this opt command line runs interchange twice and shows that there would have been endless interchange with `interchange_05()` before this patch but there is no endless interchange after this patch, which applies only to `interchange_05()` and is not related to other tests.     


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135808/new/

https://reviews.llvm.org/D135808