[PATCH] D139100: Add update_any_test_checks.py convenience utility

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Thank you for the quick review! I will give yapf a try.

> I always run update_llc_test_checks.py with --llc-binary=... and update_test_checks.py with --opt-binary=... How does this new tool support that? Or do I need to change my workflow?

It doesn't support it at the moment. In my local setup, I source an environment that has all the tools in its PATH. I find that more convenient for other reasons, so didn't try to figure out how to make the alternative work.

> Also, probably out of scope for this patch, but does it handle files that have checks generated by two or more tools, like test/CodeGen/AMDGPU/infinite-loop.ll?

Huh, interesting. I think what we'd want to do is to run all the UTC tools in sequence, from the same executor submit. I played around with this just now, and it looks like the tools don't reliably about the header notes about autogenerated tests, though. So I'd keep that as a separate change if desired.



================
Comment at: llvm/utils/update_any_test_checks.py:71
+          if not utc_tools[utc_name]:
+            print(f"{utc_name}: not found", file=sys.stderr)
+            have_error = True
----------------
mtrofin wrote:
> consider maybe also saying which file this unknown tool was found into?
Good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139100/new/

https://reviews.llvm.org/D139100