[PATCH] D139100: Add update_any_test_checks.py convenience utility

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 07:21:00 PST 2022


mtrofin accepted this revision.
mtrofin added a comment.
This revision is now accepted and ready to land.

Nice!

could you run yapf or some other formatter, to avoid long lines (easier diffing in the future). Maybe leave a comment as to how to run yapf (or whatever tool), too?

(Hmm... thinking out loud, I think maybe we can add a yapf.cfg or something like that in the root of the repo, just like we have .clang-format. Anyway, not for this patch)



================
Comment at: llvm/utils/update_any_test_checks.py:71
+          if not utc_tools[utc_name]:
+            print(f"{utc_name}: not found", file=sys.stderr)
+            have_error = True
----------------
consider maybe also saying which file this unknown tool was found into?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139100/new/

https://reviews.llvm.org/D139100



More information about the llvm-commits mailing list