[PATCH] D138891: [MachO] Prevent overflow on 32-bit platforms when calculating load command offsets
Vy Nguyen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 30 12:39:50 PST 2022
oontvoo added a comment.
In D138891#3955930 <https://reviews.llvm.org/D138891#3955930>, @awilfox wrote:
> This was my solution to the related changeset D138830 <https://reviews.llvm.org/D138830>. It simplifies the logic a lot compared to that revision while still ensuring no overflow during calculation. I did not see the other overflows so perhaps it may be better to merge the two in some way. I'm not sure how to do that in Phabricator.
sorry, missed this revision/comment previously. I agree that this is simpler change, but I was hoping to fix the other potential overflows too . (Ack'ed that D138830 <https://reviews.llvm.org/D138830>. makes the code a bit ugly :\ .... open to other suggestions, tho)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138891/new/
https://reviews.llvm.org/D138891
More information about the llvm-commits
mailing list