[PATCH] D138891: [MachO] Prevent overflow on 32-bit platforms when calculating load command offsets

A. Wilcox via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 20:24:01 PST 2022


awilfox added a comment.

This was my solution to the related changeset D138830 <https://reviews.llvm.org/D138830>.  It simplifies the logic a lot compared to that revision while still ensuring no overflow during calculation.  I did not see the other overflows so perhaps it may be better to merge the two in some way.  I'm not sure how to do that in Phabricator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138891/new/

https://reviews.llvm.org/D138891



More information about the llvm-commits mailing list