[PATCH] D138937: [AMDGPU] Update InstrCost calculation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp:272
       } else {
         ++FI.InstCost;
       }
----------------
yassingh wrote:
> arsenm wrote:
> > Probably shouldn't count free instructions here. Rather than inventing a new cost counting, can we use TTI costs?
> How do we use that cost model here? We don't have IndirectAccessCost, isLargeStrideCost, etc defined there. 
Call getInstructionCost from here? You don't need to push all the logic here into TTI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138937/new/

https://reviews.llvm.org/D138937