[PATCH] D138949: AMDGPU: Remove ImagePSV and move images to addrspace 7

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Thanks!



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:995
       Info.align.reset();
-    } else {
-      Info.fallbackAddressSpace = AMDGPUAS::BUFFER_FAT_POINTER;
     }
 
----------------
foad wrote:
> The braces are no longer needed.
Sure.


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h:385
-  const AMDGPUImagePseudoSourceValue ImagePSV;
   const AMDGPUGWSResourcePseudoSourceValue GWSResourcePSV;
 
----------------
foad wrote:
> Are you planning to remove GWSResourcePSV too?
No. That's simply because I haven't thought enough about it, don't really have the time, and it feels like enough of a rare and specialized corner that it's fine to leave it as-is. I also wouldn't want to commit to clearing out all mention of PSV's from the backend just yet. @arsenm may want to weigh in more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138949/new/

https://reviews.llvm.org/D138949