[PATCH] D138949: AMDGPU: Remove ImagePSV and move images to addrspace 7

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

I like it.



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:995
       Info.align.reset();
-    } else {
-      Info.fallbackAddressSpace = AMDGPUAS::BUFFER_FAT_POINTER;
     }
 
----------------
The braces are no longer needed.


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h:385
-  const AMDGPUImagePseudoSourceValue ImagePSV;
   const AMDGPUGWSResourcePseudoSourceValue GWSResourcePSV;
 
----------------
Are you planning to remove GWSResourcePSV too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138949/new/

https://reviews.llvm.org/D138949