[PATCH] D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used

Tue Nov 29 11:24:29 PST 2022

nickdesaulniers requested changes to this revision.
nickdesaulniers added a comment.
This revision now requires changes to proceed.

Thanks for the patch! Sorry for the delay reviewing; a few of us where off last week for the Thanksgiving holiday.

Change LGTM; but this must have a test added.

In D138757#3952450 <https://reviews.llvm.org/D138757#3952450>, @xgupta wrote:

> In D138757#3952422 <https://reviews.llvm.org/D138757#3952422>, @dblaikie wrote:
>
>> Could you add a test case?
>
> I had tried but assertions are not generating with update_llc_test_checks.py when -g flag specified with -S -emit-llvm. Should I manually write CHECK lines in test case?

Did you add a `; RUN: ` line to the beginning of your test BEFORE running update_llc_checks.py? Forgetting to do so is a common way for those scripts not to make changes.  (I'll also recommend using llvm-reduce to minimize the .ll reproducer).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138757/new/

https://reviews.llvm.org/D138757