[PATCH] D138841: AMDGPU: Fix not emitting code for exotic constructor types

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D138841#3956178 <https://reviews.llvm.org/D138841#3956178>, @sameerds wrote:

> The change description says "should" in a couple of places. If we should error out on unexpected entries, then can it be handled in this change itself? The ctor/dtor bodies in the test look well-formed, but do they actually produce the correct code in the ISA? Should we have an llc test for the same or similar input?

We shouldn't error, we certainly have all the handling for handling calls to anything. I can add an extra run line here to be sure


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138841/new/

https://reviews.llvm.org/D138841