[PATCH] D138841: AMDGPU: Fix not emitting code for exotic constructor types

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 00:11:05 PST 2022


sameerds added a comment.

The change description says "should" in a couple of places. If we should error out on unexpected entries, then can it be handled in this change itself? The ctor/dtor bodies in the test look well-formed, but do they actually produce the correct code in the ISA? Should we have an llc test for the same or similar input?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138841/new/

https://reviews.llvm.org/D138841



More information about the llvm-commits mailing list