[PATCH] D138760: BLAKE3: do not try to use neon on big-endian aarch64

HÃ¥vard Eidnes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 27 07:46:52 PST 2022


he32 created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a reviewer: gkistanova.
Herald added a project: All.
he32 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

...because this will later on hit

  #error "This implementation only supports little-endian ARM."

in `blake3_neon.c`.


Repository:
  rZORG LLVM Github Zorg

https://reviews.llvm.org/D138760

Files:
  llvm/lib/Support/BLAKE3/blake3_impl.h


Index: llvm/lib/Support/BLAKE3/blake3_impl.h
===================================================================
--- llvm/lib/Support/BLAKE3/blake3_impl.h
+++ llvm/lib/Support/BLAKE3/blake3_impl.h
@@ -64,7 +64,11 @@
 #if !defined(BLAKE3_USE_NEON) 
   // If BLAKE3_USE_NEON not manually set, autodetect based on AArch64ness
   #if defined(IS_AARCH64)
-    #define BLAKE3_USE_NEON 1
+    #if defined(__ARM_BIG_ENDIAN)
+      #define BLAKE3_USE_NEON 0
+    #else
+      #define BLAKE3_USE_NEON 1
+    #endif
   #else
     #define BLAKE3_USE_NEON 0
   #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138760.478100.patch
Type: text/x-patch
Size: 555 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221127/a99dd3b3/attachment.bin>


More information about the llvm-commits mailing list