[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.
Herald added subscribers: kosarev, ormris.
Herald added a project: All.


================
Comment at: llvm/lib/Transforms/IPO/Annotation2Metadata.cpp:51
+    auto *StrGEP = dyn_cast<ConstantExpr>(OpC->getOperand(1));
+    if (!StrGEP || StrGEP->getNumOperands() < 2)
+      continue;
----------------
This needs to handle pure Constants / direct GlobalValue references. The test added here fails when converted to opaque pointers when all of the no-op bitcasts and getelementptrs are removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91195/new/

https://reviews.llvm.org/D91195