[PATCH] D138521: [X86] Support ANDNP combine through broadcast instructions with scalar input

[Evgenii Kudriashov via Phabricator via llvm-commits]

e-kud updated this revision to Diff 478023.
e-kud added a comment.

Address to comments and put tests into https://reviews.llvm.org/D138734


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138521/new/

https://reviews.llvm.org/D138521

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp


Index: llvm/lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- llvm/lib/Target/X86/X86ISelLowering.cpp
+++ llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -7036,7 +7036,8 @@
 static SDValue IsNOT(SDValue V, SelectionDAG &DAG) {
   V = peekThroughBitcasts(V);
   if (V.getOpcode() == ISD::XOR &&
-      ISD::isBuildVectorAllOnes(V.getOperand(1).getNode()))
+      (ISD::isBuildVectorAllOnes(V.getOperand(1).getNode()) ||
+       isAllOnesConstant(V.getOperand(1))))
     return V.getOperand(0);
   if (V.getOpcode() == ISD::EXTRACT_SUBVECTOR &&
       (isNullConstant(V.getOperand(1)) || V.getOperand(0).hasOneUse())) {
@@ -48150,12 +48151,28 @@
     if (V.getOpcode() == X86ISD::VBROADCAST) {
       SDValue Src = V.getOperand(0);
       EVT SrcVT = Src.getValueType();
-      if (!SrcVT.isVector())
+      if (!SrcVT.isVector() && !(Src.hasOneUse() && V.hasOneUse()))
         return SDValue();
       if (SDValue Not = IsNOT(Src, DAG))
         return DAG.getNode(X86ISD::VBROADCAST, SDLoc(V), VT,
                            DAG.getBitcast(SrcVT, Not));
     }
+    // Fold PSHUFD(SCALAR_TO_VECTOR(NOT(Y))) -> PSHUFD(SCALAR_TO_VECTOR(Y))
+    SDValue Shuffle = peekThroughOneUseBitcasts(V);
+    if (Shuffle.getOpcode() == X86ISD::PSHUFD && Shuffle.hasOneUse()) {
+      SDValue Src = Shuffle.getOperand(0);
+      SDValue S2V = peekThroughOneUseBitcasts(Src);
+      if (S2V.getOpcode() != ISD::SCALAR_TO_VECTOR || !S2V.hasOneUse())
+        return SDValue();
+      if (SDValue Not = IsNOT(S2V.getOperand(0), DAG)) {
+        SDValue NotS2V = DAG.getNode(ISD::SCALAR_TO_VECTOR, SDLoc(S2V),
+                                     S2V.getValueType(), Not);
+        SDValue NotSrc = DAG.getBitcast(Src.getValueType(), NotS2V);
+        return DAG.getNode(X86ISD::PSHUFD, SDLoc(Shuffle),
+                           Shuffle.getValueType(), NotSrc,
+                           Shuffle.getOperand(1));
+      }
+    }
     return SDValue();
   };
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138521.478023.patch
Type: text/x-patch
Size: 1999 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221125/23cafa01/attachment.bin>