[PATCH] D138521: [X86] Support ANDNP combine through broadcast instructions with scalar input

Evgenii Kudriashov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 24 14:28:56 PST 2022


e-kud added inline comments.


================
Comment at: llvm/test/CodeGen/X86/combine-bitselect.ll:615
+  ret <4 x i32> %4
+}
+
----------------
RKSimon wrote:
> This test would probably be better inside combine-and.ll - I've improved test coverage in rG6f11c395f5899a10cbcc823cfd6ef7b08525a17e
Yes, thank you! I'll move the test to combine-and.ll. I'd like to check with both AVX512 (broadcast) and SSE (pshufd). So I'm going to add another RUN with AVX512F prefix. Should I rename existing CHECK to something like SSE42 or leave it as is? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138521/new/

https://reviews.llvm.org/D138521



More information about the llvm-commits mailing list