[PATCH] D138711: AMDGPU: Remove BufferPseudoSourceValue

Jannik Silvanus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 25 07:25:09 PST 2022


jsilvanus added a comment.

I couldn't spot any nontrivial difference in generated code -- so the new namespace-based info is equally useful (or useless?) for AA?



================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2485
+    if (Info.ptrVal)
+      MPI = MachinePointerInfo(Info.ptrVal, Info.offset);
+    else if (Info.fallbackAddressSpace)
----------------
Should we also have passed `Info.offset` before this change? Is the offset always 0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138711/new/

https://reviews.llvm.org/D138711



More information about the llvm-commits mailing list