[PATCH] D138711: AMDGPU: Remove BufferPseudoSourceValue

Fri Nov 25 07:02:21 PST 2022

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

A big +1 for the general idea.

================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:1052-1054
+    // Fallback address space for use if ptrVal is nullptr. None means unknown
+    // address space.
+    Optional<unsigned> fallbackAddressSpace;
----------------
"None means unknown address space" is a noble idea but I don't think it's providing any benefit in practice, since you only use this to initialize MachinePointerInfo, which has no concept of "unknown address space" - it just defaults to address space 0.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:866
   case PseudoSourceValue::ExternalSymbolCallEntry:
-  case PseudoSourceValue::TargetCustom:
     return AMDGPUAS::CONSTANT_ADDRESS;
----------------
Yes this was horrible and misleading. Maybe split the removal of this line (and associated test churn) into a separate patch?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138711/new/

https://reviews.llvm.org/D138711